xds interop: Fix buildscripts not continuing on a failed test suite #5937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently there's a difference between bash 3 and bash 4. OSX comes with bash 3 out-of-box, so for whoever wrote this logic it "worked on my machine". The `((` construct returns a 0 exit code if the value is non-zero. Since the value starts at 0 and we do a post-increment, it will always fail the first time. Changing it to a pre-increment fixes the problem.
sergiitk
force-pushed
the
xds-interop-fix-buildscript-suites
branch
from
5c2fc32
to
425d3f6
Compare
|
Same as grpc/grpc#32093. |
This was referenced Jan 18, 2023
easwars
approved these changes
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
sergiitk
added a commit
to sergiitk/grpc-go
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there's a difference between bash 3 and bash 4. OSX comes with bash 3 out-of-box, so for whoever wrote this logic it "worked on my machine".
The
((construct returns a 0 exit code if the value is non-zero. Since the value starts at 0 and we do a post-increment, it will always fail the first time. Changing it to a pre-increment fixes the problem.RELEASE NOTES: n/a