Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weightedroundrobin: prefer application_utilization to cpu_utilization #6358

Merged
merged 1 commit into from
Jun 7, 2023
Merged

weightedroundrobin: prefer application_utilization to cpu_utilization #6358

merged 1 commit into from
Jun 7, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jun 7, 2023 •
edited
Loading

Also includes #6357 as the first commit.

Implements the changes from grpc/proposal#373.

RELEASE NOTES: none

@dfawley dfawley added the Type: Feature New features or improvements in behavior label Jun 7, 2023
@dfawley dfawley added this to the 1.56 Release milestone Jun 7, 2023
@dfawley dfawley requested a review from zasweq June 7, 2023 17:28
zasweq
zasweq approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had some comments on commit it's based off though. The logic in balancer.go lgtm/checks out.

balancer/weightedroundrobin/balancer_test.go Show resolved Hide resolved
balancer/weightedroundrobin/balancer_test.go
defer cancel()
testCases := []struct {
name string
utilSetter func(orca.ServerMetricsRecorder, float64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: utilSetter of what?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util here = "utilization" not "utility", so: "setter of utilization".

@zasweq zasweq assigned dfawley and unassigned zasweq Jun 7, 2023
@dfawley dfawley merged commit 2ac1aae into grpc:master Jun 7, 2023
1 check passed
@dfawley dfawley deleted the wrr_app_util branch June 7, 2023 20:56
dfawley added a commit to dfawley/grpc-go that referenced this pull request Jun 7, 2023
@dfawley
weightedroundrobin: prefer application_utilization to cpu_utilization (…
3e0bf86 
…grpc#6358)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees

@dfawley dfawley

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.56 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @zasweq