deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto

[Clement-Jean]

This is the second part of #6736 which is moving away from github.com/golang/protobuf in favor of google.golang.org/protobuf/proto

RELEASE NOTES:

• Use google.golang.org/protobuf/proto instead of github.com/golang/protobuf.

[Clement-Jean]

@dfawley please check this PR. It might need another code review just to be sure that after merging with the new updates, it is still ok.

[Clement-Jean]

@arvindbr8 I'm not entirely sure about the "unresolved" comment. What did you mean?

@dfawley There seem to be still some work to do to remove the old package. Could you take a look at the remaining usages (channelz, credentials, internal/pretty, and xds/internal/xdsclient/bootstrap) and tell me if any of these can be translated with the protoadapt package? If yes, I'll work on that.

[dfawley]

@arvindbr8 I'm not entirely sure about the "unresolved" comment. What did you mean?

I think he meant status.WithDetails's method signature which I thought when I looked yesterday did not use protoadapt.MessageV1, but maybe I was misreading. Anyway it looks right to me now. 🤷

[dfawley]

There seem to be still some work to do to remove the old package. Could you take a look at the remaining usages (channelz, credentials, internal/pretty, and xds/internal/xdsclient/bootstrap) and tell me if any of these can be translated with the protoadapt package? If yes, I'll work on that.

Oh true, there is still more to do.

I have a huge PR reworking channelz, so please still wait on that. But the other ones should be fine if you are willing to work on them. Thank you!

[Clement-Jean]

The remaining mention to github.com/golang/protobuf seems to be indirect dependency, some mentions in scripts and channelz.

Could you take a look at the changes? especially in reflection/grpc_testing_not_regenerate, I'm not sure if it is correct. I splitted the testv3.go into two files (pb and grpc) but if you need to merge them let me know.

[dfawley]

Would you mind reverting all those changes since the last review so we can submit the already-reviewed code without delay? You can move them into another branch and we can go from there.

Thanks!

[Clement-Jean]

@dfawley This should be reverted

[arvindbr8]

LGTM, Thanks @Clement-Jean

[RJKeevil]

Hi, I don't know whether there is a third phase planned to this task, but in my application there is one remaining place where i see the deprecated dependency being brought in. Credentials.go in google.golang.org/grpc/credentials (

grpc-go/credentials/credentials.go

Line 31 in 5ccf176

"github.com/golang/protobuf/proto"

) still has an import on github.com/golang/protobuf/proto . Can this be removed also? I can attempt a PR if it helps.

[Clement-Jean]

@RJKeevil We cannot remove that just yet because of possible conflicts due to a rewrite. However it's planned and I will work on it ASAP 😊

[Clement-Jean]

Just noticed issue #6969 is closed. Does this mean, we can do the last bit of work? @dfawley

[dfawley]

Yes, I think we're all clear now to finish it.

Unfortunately, it looks like we'll still keep the dependency in perpetuity because of testing in https://github.com/grpc/grpc-go/blob/cce163274b6cb9de2b2bf0bc742384e5755fee42/reflection/grpc_testing_not_regenerate/testv3.go#L41C9-L41C41