ringhash: more e2e tests from c-core #7334
Conversation
atollena
force-pushed
the
issue-6072-part-2
branch
from
8dafccc to
d6d26a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7334 +/- ##
==========================================
+ Coverage 81.50% 81.58% +0.07%
==========================================
Files 350 350
Lines 26846 26877 +31
==========================================
+ Hits 21882 21928 +46
+ Misses 3778 3761 -17
- Partials 1186 1188 +2
|
Follow up to grpc#7271 to fix grpc#6072. This adds a dozen more end to end tests. There are tests that I did not port, specifically: - TestRingHash_TransientFailureSkipToAvailableReady was flaky when I ported it, so I removed it while investigating. - TestRingHash_SwitchToLowerPriorityAndThenBack was also flaky, I also removed it while investigating. - TestRingHash_ContinuesConnectingWithoutPicksOneSubchannelAtATime, I'm not sure we implement this behavior, and if we do, it's not working the same way as in c-core, where the order of subchannel connection attempts is based on the resolver address order rather than the ring order. I will follow up with fixes for each one of the remaining tests.
atollena
force-pushed
the
issue-6072-part-2
branch
from
d6d26a5 to
321d866
Compare
|
@atollena : Looks like there are some merge conflicts. Could you please take care of them before I start looking. Thanks. |
Done. This is ready for review. |
|
FYI the remaining 4 tests that were failing, mentioned in the description, are caused by #7363. |
|
Thanks @easwars, I answered all your comments. This is ready for another round. |
|
vet failure is a false positive due to #7421. |
Thank you very much for patiently addressing all comments and thank you again for doing this. |
Follow up to #7271 to fix #6072.
This adds a dozen more end to end tests.
There are tests that I did not port, specifically:
TestRingHash_SwitchToLowerPriorityAndThenBackwas also flaky when ported as-is, I also removed it while investigating.TestRingHash_TransientFailureSkipToAvailableReadywas flaky when ported as-is, so I removed it while investigating.TestRingHash_ReattemptWhenAllEndpointsUnreachablewas flaky when ported as-is, so I removed it while investigating.TestRingHash_ContinuesConnectingWithoutPicksOneSubchannelAtATime, I'm not sure we implement this behavior, and if we do, it's not working the same way as in c-core, where the order of subchannel connection attempts is based on the resolver address order rather than the ring order.I will follow up with fixes for each one of the remaining tests.
RELEASE NOTES: none