-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credentials/tls: default GRPC_ENFORCE_ALPN_ENABLED to true #7535
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7535 +/- ##
==========================================
- Coverage 81.91% 81.75% -0.17%
==========================================
Files 361 361
Lines 27825 27825
==========================================
- Hits 22794 22748 -46
- Misses 3841 3869 +28
- Partials 1190 1208 +18
|
Let's wait a few weeks for this since we have a lot of other semi-risky things in flight right now. |
Waiting to fix internal users before submitting this PR. |
Small note on the release note:
Is the last sentence correct? Shouldn't it just read "The environment variable to revert this behavior will be removed in an upcoming release."? |
You're correct. It was a copy/paste error. Updated the release note |
Related issue: #434
RELEASE NOTES:
GRPC_ENFORCE_ALPN_ENABLED
tofalse
(case insensitive). Please file a bug if you encounter any issues with this behaviour. The environment variable to revert this behaviour will be removed in an upcoming release.