Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding: delete v1 proto codec and use one map for registry #7557

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 23, 2024

cc @PapaCharlie

Without this change, existing users that overwrote the v1 "proto" codec with special changes will have a behavior change, as we will choose the v2 "proto" codec over theirs. Also there seems to be little value to keeping the v1 proto codec around since we would never use it.

RELEASE NOTES: none

@dfawley dfawley added this to the 1.66 Release milestone Aug 23, 2024
@dfawley dfawley requested a review from arvindbr8 August 23, 2024 17:31
@dfawley dfawley changed the title encoding: delete v1 proto codec and prefer v1 codecs over v2 codecs encoding: delete v1 proto codec and use one map for registry Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.71%. Comparing base (3d95421) to head (0ede3f6).
Report is 1 commits behind head on master.

Files Patch % Lines
encoding/proto/proto.go 72.72% 4 Missing and 2 partials ⚠️
codec.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7557      +/-   ##
==========================================
- Coverage   81.79%   81.71%   -0.09%     
==========================================
  Files         362      361       -1     
  Lines       27832    27816      -16     
==========================================
- Hits        22765    22729      -36     
- Misses       3856     3875      +19     
- Partials     1211     1212       +1     
Files Coverage Δ
encoding/encoding.go 56.25% <100.00%> (-17.09%) ⬇️
encoding/encoding_v2.go 60.00% <100.00%> (+4.44%) ⬆️
codec.go 10.52% <50.00%> (-72.09%) ⬇️
encoding/proto/proto.go 66.66% <72.72%> (ø)

... and 19 files with indirect coverage changes

@dfawley dfawley merged commit cfd14ba into grpc:master Aug 23, 2024
14 checks passed
@dfawley dfawley deleted the codec_vers_default branch August 23, 2024 23:26
dfawley added a commit to dfawley/grpc-go that referenced this pull request Aug 26, 2024
dfawley added a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants