credentials: don't overwrite ServerName in given config #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menghanl @iamqizhao Can you take a look? We want to get this merged soon. This blocks etcd release, blocks kubernetes + etcd3 integration. |
| @@ -151,14 +151,16 @@ func (c *tlsCreds) ClientHandshake(addr string, rawConn net.Conn, timeout time.D | |||
| errChannel <- timeoutError{} | |||
| }) | |||
| } | |||
| // use local cfg to avoid clobbering ServerName if multiple endpoints | |||
There was a problem hiding this comment.
seems the comment is not complete? can you complete the sentence?
|
LGTM when the comment is fixed. |
heyitsanthony
force-pushed
the
fix-cred-clobber
branch
from
2f0d911
to
9a97937
Compare
|
@iamqizhao OK, fixed the comment |
The first endpoint will set the ServerName which will then be used by the second endpoint, causing the transport to reject the second endpoint since the server cert won't match the server name.
This was referenced Jul 22, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first endpoint will set the ServerName which will then be used by
the second endpoint, causing the transport to reject the second endpoint
since the server cert won't match the server name.