Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #7571 and #7579 to v1.66.x release branch #7616

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Sep 11, 2024

Cherry-pick #7571 and #7579

RELEASE NOTES:

  • mem: Fix minor server-side regression when pooling large (>1KiB) incoming request buffers
  • experimental/stats: Remove dependency on testing package

@purnesh42H purnesh42H changed the title Cherry pick 7571 7579 Cherry pick #7571 and #7579 to v1.66.x release branch Sep 11, 2024
@purnesh42H purnesh42H added the Type: Meta Github repo, process, etc label Sep 11, 2024
@purnesh42H purnesh42H added this to the 1.66 Release milestone Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (7185cf4) to head (057d663).
Report is 1 commits behind head on v1.66.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7616      +/-   ##
===========================================
+ Coverage    81.74%   81.83%   +0.08%     
===========================================
  Files          361      361              
  Lines        27858    27858              
===========================================
+ Hits         22773    22798      +25     
+ Misses        3875     3861      -14     
+ Partials      1210     1199      -11     
Files with missing lines Coverage Δ
experimental/stats/metricregistry.go 94.44% <100.00%> (-0.08%) ⬇️
mem/buffer_slice.go 96.20% <ø> (ø)
server.go 81.95% <100.00%> (+0.11%) ⬆️

... and 20 files with indirect coverage changes

@arjan-bal
Copy link
Contributor

Can you keep this PR for a single cherry-pick and open another PR for the second one?

@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Sep 11, 2024
@purnesh42H
Copy link
Contributor Author

Can you keep this PR for a single cherry-pick and open another PR for the second one?

Discussed offline. Followed this example #7019

@purnesh42H purnesh42H assigned arjan-bal and unassigned purnesh42H Sep 11, 2024
@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Sep 11, 2024
@arjan-bal arjan-bal added Type: Bug and removed Type: Meta Github repo, process, etc labels Sep 11, 2024
@arjan-bal arjan-bal mentioned this pull request Sep 11, 2024
@purnesh42H purnesh42H merged commit 12487c8 into grpc:v1.66.x Sep 11, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants