Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials/google: Add cloud-platform scope for ADC #7887

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

halvards
Copy link
Contributor

@halvards halvards commented Dec 2, 2024

Fixes #7886

RELEASE NOTES:

  • credentials/google: set scope for application default credentials

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (4c07bca) to head (35e8dd5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7887      +/-   ##
==========================================
+ Coverage   81.84%   82.14%   +0.29%     
==========================================
  Files         377      377              
  Lines       38120    38120              
==========================================
+ Hits        31201    31312     +111     
+ Misses       5603     5518      -85     
+ Partials     1316     1290      -26     
Files with missing lines Coverage Δ
credentials/google/google.go 77.33% <100.00%> (ø)

... and 22 files with indirect coverage changes

@rockspore rockspore removed their assignment Dec 2, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@dfawley dfawley changed the title credentials/google/google: Add cloud-platform scope for ADC credentials/google: Add cloud-platform scope for ADC Dec 2, 2024
@dfawley dfawley merged commit 3ce87dd into grpc:master Dec 2, 2024
15 checks passed
@halvards halvards deleted the fix-7886 branch December 2, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

credentials/google/google: missing OAuth scopes for ADC
5 participants