-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bazel: Use the
artifact
macro for loading maven deps
The recommended way to load dependencies from `rules_jvm_external` is to make use of the `@maven` workspace, and the most readable way of doing that is to use the `artifact` macro provides. This removes the need to generate the "compat" namespaces, which `rules_jvm_external` provided for backwards compatibility with older releases. This change also sets things up for supporting `bzlmod`: this requires all workspaces accessed by a library to be named "up front" in the `MODULE.bazel` file. This way, the only repo that needs to be exported is `@maven`, rather than the current huge list.
- Loading branch information
1 parent
4ef1bad
commit 0064991
Showing
22 changed files
with
169 additions
and
139 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,18 @@ | ||
load("@rules_jvm_external//:defs.bzl", "artifact") | ||
|
||
java_library( | ||
name = "inprocess", | ||
srcs = glob([ | ||
"src/main/java/io/grpc/inprocess/*.java", | ||
]), | ||
visibility = ["//visibility:public"], | ||
deps = [ | ||
"//core:internal", | ||
"//api", | ||
"//context", | ||
"@com_google_code_findbugs_jsr305//jar", | ||
"@com_google_errorprone_error_prone_annotations//jar", | ||
"@com_google_guava_guava//jar", | ||
"@com_google_j2objc_j2objc_annotations//jar", | ||
"//core:internal", | ||
artifact("com.google.code.findbugs:jsr305"), | ||
artifact("com.google.errorprone:error_prone_annotations"), | ||
artifact("com.google.guava:guava"), | ||
artifact("com.google.j2objc:j2objc-annotations"), | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
load("@rules_jvm_external//:defs.bzl", "artifact") | ||
|
||
# Publicly exposed in //netty package. Purposefully does not export any symbols. | ||
java_library( | ||
name = "shaded", | ||
visibility = ["//netty:__pkg__"], | ||
runtime_deps = [ | ||
"//netty", | ||
"@io_netty_netty_tcnative_boringssl_static//jar", | ||
"@io_netty_netty_tcnative_classes//jar", | ||
"@io_netty_netty_transport_native_unix_common//jar", | ||
"@io_netty_netty_transport_native_epoll_linux_x86_64//jar", | ||
artifact("io.netty:netty-tcnative-boringssl-static"), | ||
artifact("io.netty:netty-tcnative-classes"), | ||
artifact("io.netty:netty-transport-native-unix-common"), | ||
artifact("io.netty:netty-transport-native-epoll_linux_x86_64"), | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.