opentelemetry: Missing locality should be empty string

From gRFC A78: > If no locality information is available, the label will be set to the > empty string.
grpc · May 9, 2024 · 8808d63 · 8808d63
1 parent a239063
commit 8808d63
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java b/opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java
@@ -213,7 +213,7 @@ void recordFinishedAttempt() {
       if (module.localityEnabled) {
         String savedLocality = locality;
         if (savedLocality == null) {
-          savedLocality = "unknown";
+          savedLocality = "";
         }
         builder.put(LOCALITY_KEY, savedLocality);
       }

diff --git a/opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java b/opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java
@@ -974,7 +974,7 @@ public void clientLocalityMetrics_missing() {
 
     io.opentelemetry.api.common.Attributes clientAttributesWithLocality
         = clientAttributes.toBuilder()
-        .put(LOCALITY_KEY, "unknown")
+        .put(LOCALITY_KEY, "")
         .build();
 
     assertThat(openTelemetryTesting.getMetrics())