Extract a few common tag valalues.

grpc · May 24, 2018 · ea3d425 · ea3d425
1 parent b7fbc10
commit ea3d425
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/core/src/main/java/io/grpc/internal/CensusStatsModule.java b/core/src/main/java/io/grpc/internal/CensusStatsModule.java
@@ -328,10 +328,11 @@ static final class ClientCallTracer extends ClientStreamTracer.Factory {
       this.module = module;
       this.fullMethodName = checkNotNull(fullMethodName, "fullMethodName");
       this.parentCtx = checkNotNull(parentCtx);
+      TagValue methodTag = TagValue.create(fullMethodName);
       this.startCtx =
           module.tagger.toBuilder(parentCtx)
-          .put(RpcMeasureConstants.RPC_METHOD, TagValue.create(fullMethodName))
-          .put(RpcMeasureConstants.GRPC_CLIENT_METHOD, TagValue.create(fullMethodName))
+          .put(RpcMeasureConstants.RPC_METHOD, methodTag)
+          .put(RpcMeasureConstants.GRPC_CLIENT_METHOD, methodTag)
           .build();
       this.stopwatch = module.stopwatchSupplier.get().start();
       this.recordFinishedRpcs = recordFinishedRpcs;
@@ -419,14 +420,13 @@ void callEnded(Status status) {
       if (!status.isOk()) {
         measureMap.put(RpcMeasureConstants.RPC_CLIENT_ERROR_COUNT, 1);
       }
+      TagValue statusTag = TagValue.create(status.getCode().toString());
       measureMap.record(
           module
               .tagger
               .toBuilder(startCtx)
-              .put(RpcMeasureConstants.RPC_STATUS, TagValue.create(status.getCode().toString()))
-              .put(
-                  RpcMeasureConstants.GRPC_CLIENT_STATUS,
-                  TagValue.create(status.getCode().toString()))
+              .put(RpcMeasureConstants.RPC_STATUS, statusTag)
+              .put(RpcMeasureConstants.GRPC_CLIENT_STATUS, statusTag)
               .build());
     }
   }
@@ -629,14 +629,13 @@ public void streamClosed(Status status) {
       if (!status.isOk()) {
         measureMap.put(RpcMeasureConstants.RPC_SERVER_ERROR_COUNT, 1);
       }
+      TagValue statusTag = TagValue.create(status.getCode().toString());
       measureMap.record(
           module
               .tagger
               .toBuilder(parentCtx)
-              .put(RpcMeasureConstants.RPC_STATUS, TagValue.create(status.getCode().toString()))
-              .put(
-                  RpcMeasureConstants.GRPC_SERVER_STATUS,
-                  TagValue.create(status.getCode().toString()))
+              .put(RpcMeasureConstants.RPC_STATUS, statusTag)
+              .put(RpcMeasureConstants.GRPC_SERVER_STATUS, statusTag)
               .build());
     }
 
@@ -665,11 +664,12 @@ public ServerStreamTracer newServerStreamTracer(String fullMethodName, Metadata
       if (parentCtx == null) {
         parentCtx = tagger.empty();
       }
+      TagValue methodTag = TagValue.create(fullMethodName);
       parentCtx =
           tagger
               .toBuilder(parentCtx)
-              .put(RpcMeasureConstants.RPC_METHOD, TagValue.create(fullMethodName))
-              .put(RpcMeasureConstants.GRPC_SERVER_METHOD, TagValue.create(fullMethodName))
+              .put(RpcMeasureConstants.RPC_METHOD, methodTag)
+              .put(RpcMeasureConstants.GRPC_SERVER_METHOD, methodTag)
               .build();
       return new ServerTracer(
           CensusStatsModule.this,