Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support maxConcurrentCallsPerConnection in OkHttpServer #11062

Closed
hypnoce opened this issue Mar 31, 2024 · 0 comments
Closed

Support maxConcurrentCallsPerConnection in OkHttpServer #11062

hypnoce opened this issue Mar 31, 2024 · 0 comments
Labels
enhancement

Comments

@hypnoce
Copy link
Contributor

hypnoce commented Mar 31, 2024

OkHttpServer does not provide a way to limit the number of max concurrent streams per connection like netty does.
OkHttpClient do handle max concurrent streams setting sent by the server.

OkHttpServerBuilder can provide a way to set max concurrent calls per connection like netty :

grpc-java/netty/src/main/java/io/grpc/netty/NettyServerBuilder.java

Line 404 in 0866e71

public NettyServerBuilder maxConcurrentCallsPerConnection(int maxCalls) {

Then it has to send this settings to the client per connection and check at every new stream creation (header handling)
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 31, 2024
@hypnoce
OkHttpServer: support maxConcurrentCallsPerConnection (Fixes grpc#11062…
a42b7bd 
…).

* Add option in OkHttpServerBuilder
* Add value as MAX_CONCURRENT_STREAM setting in settings frame sent by the server to the client per connection
* Enforce limit by sending a RST frame with REFUSED_STREAM error
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 31, 2024
@hypnoce
OkHttpServer: support maxConcurrentCallsPerConnection (Fixes grpc#11062…
553f169 
…).

* Add option in OkHttpServerBuilder
* Add value as MAX_CONCURRENT_STREAM setting in settings frame sent by the server to the client per connection
* Enforce limit by sending a RST frame with REFUSED_STREAM error
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 31, 2024
@hypnoce
OkHttpServer: support maxConcurrentCallsPerConnection (Fixes grpc#11062…
bbd84b2 
…).

* Add option in OkHttpServerBuilder
* Add value as MAX_CONCURRENT_STREAM setting in settings frame sent by the server to the client per connection
* Enforce limit by sending a RST frame with REFUSED_STREAM error
@temawi temawi closed this as completed in 8050723 Apr 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hypnoce