Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The onReadyThreshold property cannot be configured in the application[grpc version: 1.64.0] #11289

Closed
hlx502 opened this issue Jun 14, 2024 · 2 comments
Labels
Milestone

Comments

@hlx502
Copy link
Contributor

hlx502 commented Jun 14, 2024

  1. Although grpc currently supports configuring onReadyThreshold, the withOnReadyThreshold() method is not provided in AbstractStub
    image
  2. Because the onReadyThreshold property is not copied in the toBuilder() method of CallOptions. Even if onReadyThreshold is configured in the interceptor, it will be overwritten to null in the end.
    image
@hlx502 hlx502 changed the title The onReadyThreshold property cannot be configured in the application The onReadyThreshold property cannot be configured in the application[grpc version: 1.64.0] Jun 14, 2024
@ejona86
Copy link
Member

ejona86 commented Jun 14, 2024

Mind sending a PR? That second part definitely looks like a bug. It doesn't seem stub was discussed earlier; I don't see any evidence it was left out on purpose, other than it wasn't needed/helpful/whatever at the time. It seems fair to include on the stub.

The broken toBuilder() would only matter if something later modified the call options, but gRPC itself will modify the call options at at times...

@hlx502
Copy link
Contributor Author

hlx502 commented Jun 15, 2024

yes, I sent a PR. Please review it if you have time.
https://github.com/grpc/grpc-java/pull/11295/files

@hlx502 hlx502 closed this as completed Jun 15, 2024
@hlx502 hlx502 reopened this Jun 16, 2024
@ejona86 ejona86 added the bug label Jun 20, 2024
@ejona86 ejona86 added this to the 1.66 milestone Jun 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants