Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-java supports onReadyThreshold property setting #11295

Closed
wants to merge 13 commits into from

Conversation

hlx502
Copy link
Contributor

@hlx502 hlx502 commented Jun 15, 2024

issues

#11289

modify

  1. Support setting onReadyThreshold through AbstractStub
  2. Add copy of the onReadyThreshold property when copying CallOptions(fix bug)

2. Add copy of the onReadyThreshold property when copying CallOptions(fix bug)
Copy link

linux-foundation-easycla bot commented Jun 15, 2024

CLA Missing ID CLA Not Signed

@ejona86 ejona86 requested a review from kannanjgithub June 20, 2024 16:55
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 20, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 20, 2024
@ejona86
Copy link
Member

ejona86 commented Jun 21, 2024

@hlx502, if you squash your commits, it should fix the CLA issue. It looks like you used a different email for one of the commits.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 21, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 21, 2024
hlx502 added 4 commits June 25, 2024 11:51
2. Add copy of the onReadyThreshold property when copying CallOptions(fix bug)
@hlx502 hlx502 closed this Jun 25, 2024
@hlx502
Copy link
Contributor Author

hlx502 commented Jun 25, 2024

@hlx502, if you squash your commits, it should fix the CLA issue. It looks like you used a different email for one of the commits.

I tried to compress the commit, but it seems there are still some problems. I resubmitted a new PR: #11320

@hlx502 hlx502 deleted the develop/240615/OnReadyThreshold branch June 25, 2024 08:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants