Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update okhttp version from 2.5.0 to 2.7.4 #6725

Closed
sourabhsparkala opened this issue Feb 19, 2020 · 3 comments
Closed

Update okhttp version from 2.5.0 to 2.7.4 #6725

sourabhsparkala opened this issue Feb 19, 2020 · 3 comments

Comments

@sourabhsparkala
Copy link
Contributor

This update of com.squareup.okhttp:okhttp:jar version from 2.5.0 to 2.7.4 would help resolve a reported vulnerability CVE-2016-2402

It would help us a great deal, if you can update the version
As shown in the mvn tree

| | +- io.grpc:grpc-okhttp:jar:1.17.1:compile
| | | \- com.squareup.okhttp:okhttp:jar:2.5.0:compile

Also, we would appreciate it if you can let us know, whether it possible to do a quick release as early as possible.

Requesting you to downport the com.squareup.okhttp:okhttp:jar version fix update to io.grpc:grpc-okhttp:jar:1.17.1 as well

@ericgribkoff
Copy link
Contributor

gRPC Java uses very little of the internals of okhttp; in particular, we do not use OkHttp's certificate pinning so this vulnerability does not apply to gRPC Java users. Please see the discussion from #6119 (comment) for more details around what (minimal) parts of OkHttp we actually use.

@sourabhsparkala
Copy link
Contributor Author

gRPC Java uses very little of the internals of okhttp; in particular, we do not use OkHttp's certificate pinning so this vulnerability does not apply to gRPC Java users. Please see the discussion from #6119 (comment) for more details around what (minimal) parts of OkHttp we actually use.

Thank you for the clarification 👍

@creamsoup
Copy link
Contributor

upgraded is done vis #6726, as discussed above and in the PR. we don't need to patch release this fix because grpc-okhttp is not affected by the linked CVE.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants