xDS: implement ADS stream flow control mechanism #10674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Nov 16, 2023
YifeiZhuang
force-pushed
the
flow-control
branch
from
6adfd3e
to
169dacc
Compare
ejona86
reviewed
Nov 22, 2023
YifeiZhuang
force-pushed
the
flow-control
branch
from
ceba733
to
e9f81f6
Compare
YifeiZhuang
force-pushed
the
flow-control
branch
from
8f6143b
to
176afae
Compare
ejona86
reviewed
Dec 8, 2023
ejona86
reviewed
Dec 8, 2023
ejona86
approved these changes
Dec 9, 2023
| @@ -650,13 +655,20 @@ void onData(ParsedResource<T> parsedResource, String version, long updateTime) { | |||
| resourceDeletionIgnored = false; | |||
| } | |||
| if (!Objects.equals(oldData, data)) { | |||
| for (ResourceWatcher<T> watcher : watchers) { | |||
| notifyWatcher(watcher, data); | |||
| for (ResourceWatcher<T> watcher : watchers.keySet()) { | |||
There was a problem hiding this comment.
Consider using entrySet(), so you don't have to look up the value. Ditto below.
larry-safran
approved these changes
Dec 15, 2023
| } | ||
|
|
||
| DiscoveryRpcCall call = resourceDiscoveryCalls.poll(); | ||
| call.verifyRequest(type, Collections.singletonList(name), "", "", NODE); |
There was a problem hiding this comment.
poll could return null if resourceDiscoveryCalls is empty. It would be better to do an explicit check with an explanatory message than get an NPE.
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Dec 27, 2023
This reverts commit 0a704a5.
YifeiZhuang
added a commit
that referenced
this pull request
Dec 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix grpc/grpc#34099
@ejona86 early feedback about the overall shape would be great, tests needs to be cleaned up.