Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache failed futures for async security policies indefinitely. #10743

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Do not cache failed futures for async security policies indefinitely. #10743

merged 5 commits into from
Jan 3, 2024

Commits on Dec 12, 2023

  1. Do not cache failed futures for async security policies indefinitely. 

    Currently, if caching is enabled (as is often the case) and AsyncSecurityPolicy returns a failed future, then this future is cached forever, without giving the SecurityPolicy implementation a chance to be retried. Going forward, new invocations will trigger new security checks if the last one could not be completed successfuly.

Part of grpc#10566.
    @mateusazis
    mateusazis committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5926b7e View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Using future callback to remove cancelled/failed auth future from map.

    @mateusazis
    mateusazis committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    06ec101 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Use Futures.addCallback. Simplify concurrency.

    @mateusazis
    mateusazis committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    1691987 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. remove IllegalStateException

    @mateusazis
    mateusazis committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    cb5175d View commit details
    Browse the repository at this point in the history

  2. Add unit test to confirm that the error message gets propagated.

    @mateusazis
    mateusazis committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    245cf68 View commit details
    Browse the repository at this point in the history