Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: Ignore known conscrypt socket close issue #10811

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Jan 10, 2024

This stops an exception from being thrown when a known Conscrypt synchronization issue happens.

Note that lack of coverage on the PR is because this issue only happens infrequently in highly concurrent systems and a unit test would not be able to catch it.

Fixes: #10800

@temawi temawi requested a review from ejona86 January 10, 2024 18:12
@temawi temawi merged commit 6605649 into grpc:master Jan 10, 2024
13 of 14 checks passed
@temawi temawi deleted the binder-socket-close-fix branch January 10, 2024 19:01
temawi added a commit to temawi/grpc-java that referenced this pull request Jan 10, 2024
This stops an exception from being thrown when a known Conscrypt synchronization issue happens.
temawi added a commit that referenced this pull request Jan 10, 2024
This stops an exception from being thrown when a known Conscrypt synchronization issue happens.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled java.lang.NullPointerException: bio == null in io.grpc.okhttp.internal.framed.Http2$Reader.close
2 participants