Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setOnReadyThreshold() a noop method instead of abstract. #11044

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

ran-su
Copy link
Member

@ran-su ran-su commented Mar 27, 2024

This change fixes existing users broke by #10977

@ran-su ran-su marked this pull request as ready for review March 27, 2024 21:07
@ran-su ran-su requested a review from ejona86 March 27, 2024 21:07
@ejona86
Copy link
Member

ejona86 commented Mar 27, 2024

CC @jduo

@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Mar 27, 2024
@ran-su ran-su merged commit 37263b7 into grpc:master Mar 27, 2024
14 of 15 checks passed
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Mar 29, 2024
…1044)

Make setOnReadyThreshold() a noop method instead of abstract
YifeiZhuang pushed a commit that referenced this pull request Apr 2, 2024
#11059)

Make setOnReadyThreshold() a noop method instead of abstract

Co-authored-by: Ran <ran-su@users.noreply.github.com>
@YifeiZhuang YifeiZhuang removed the TODO:backport PR needs to be backported. Removed after backport complete label Apr 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants