Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include com_google_protobuf_javalite to MODULE.bazel to fix bzlmod querying graph in end-user repo #11147

Merged
merged 6 commits into from
May 15, 2024
Merged

Include com_google_protobuf_javalite to MODULE.bazel to fix bzlmod querying graph in end-user repo #11147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d2898e
Fix 3d party dependency use_repo
firov May 3, 2024
abd2379
remove protobuf as it is already added as module dep
firov May 3, 2024
550f120
fix
firov May 3, 2024
080e377
fix
firov May 3, 2024
ae0e1de
fix
firov May 3, 2024
a058608
return com_google_protobuf_javalite archive and use it in MODULE.bazel
firov May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ use_repo(
non_module_deps,
"com_github_cncf_xds",
"envoy_api",
"com_google_protobuf_javalite",
"io_grpc_grpc_proto",
)

Expand Down
2 changes: 1 addition & 1 deletion repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def grpc_java_repositories(bzlmod = False):
)
if not bzlmod and not native.existing_rule("com_google_protobuf"):
com_google_protobuf()
if not bzlmod and not native.existing_rule("com_google_protobuf_javalite"):
if not native.existing_rule("com_google_protobuf_javalite"):
com_google_protobuf_javalite()
if not bzlmod and not native.existing_rule("com_google_googleapis"):
http_archive(
Expand Down
Loading