-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Add GCP CSM Observability example #11267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use jib
. As in another example:
grpc-java/examples/example-hostname/build.gradle
Lines 61 to 69 in 791f894
jib { | |
from.image = "gcr.io/distroless/java17-debian12" | |
container.ports = ['50051'] | |
outputPaths { | |
tar = 'build/example-hostname.tar' | |
digest = 'build/example-hostname.digest' | |
imageId = 'build/example-hostname.id' | |
} | |
} |
If we want, we can have the dockerfile as well, but we shouldn't root it in grpc-java but instead expect it to be built in the example-gcp-csm-observability directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is related to automating container image generation, I will add it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it was more I don't want us to use Dockerfile because they are harder to integrate and produce worse results. But since you've gotten the Dockerfile approach working, I guess that's fine... but... yeah, I had wanted us to push jib in the documentation.
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityClient.java
Outdated
Show resolved
Hide resolved
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityClient.java
Outdated
Show resolved
Hide resolved
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityClient.java
Show resolved
Hide resolved
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityServer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix up the comment style, then LGTM
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it was more I don't want us to use Dockerfile because they are harder to integrate and produce worse results. But since you've gotten the Dockerfile approach working, I guess that's fine... but... yeah, I had wanted us to push jib in the documentation.
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityClient.java
Outdated
Show resolved
Hide resolved
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityClient.java
Outdated
Show resolved
Hide resolved
...sm-observability/src/main/java/io/grpc/examples/csmobservability/CsmObservabilityServer.java
Outdated
Show resolved
Hide resolved
Add GCP CSM observability example client and example server.
Add GCP CSM observability example client and example server.
This PR adds a CSM Observability example. This is intended to be built as docker images and deployed as part of CSM observability user guide.