-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 #11294
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8bde1c9
Change the logic for identifying changes to the read index when mergi…
larry-safran 5353531
Change the logic for identifying changes to the read index when mergi…
larry-safran a87d7e7
Also use the old readerIndex, not just arrayOffset, to set the new re…
larry-safran 294ceff
Fix debugging leftover
larry-safran 5fd7d98
Fix mistaken file update
larry-safran b2cfffa
Utilize netty-buffer version number to choose approach to setting rea…
larry-safran 40bb7f4
Improve version comparison to handle versions prior to 4.1.100
larry-safran 2c18d7b
Change offset calculation logic to be based on the difference between…
larry-safran d8a8c44
Use the same approach for all netty versions.
larry-safran 23de0bf
Use addComposite instead of addFlattenedComposite and not append to c…
larry-safran a36a797
Use addComposite instead of addFlattenedComposite and not append to c…
larry-safran 4651e20
Add Javadoc
larry-safran 6c8699f
Add Javadoc
larry-safran e941c01
Respond to review comments.
larry-safran 7ff0d69
Replace most addFlattenedComponents with addComponent.
larry-safran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this phrasing in red font makes a lot of sense here. It's not actionable for the user of this class. If it's for modifying the class itself, should we just note that on
mergeWithCompositeTail
method instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't just for
mergeWithCompositeTail
. It is for the entire class. Socumulate()
andaddTail
are impacted as well.