netty:Fix Netty composite buffer merging to be compatible with Netty 4.1.111 (1.63.x backport) #11304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.1.111 (grpc#11294) * Use addComponent instead of addFlattenedComponent and do not append to components that are composites.
ejona86
approved these changes
Jun 21, 2024
sergiitk
approved these changes
Jun 21, 2024
|
@larry-safran will this fix be released in 1.63.2 (or 1.63.3) anytime soon? I saw 1.64.1 and 1.65.0 already released containing this fix. Thanks in advance. |
|
@juliojgd, there's vacations/holidays this week and our release infrastructure broke on July 1st because CentOS 7 died. So it will definitely be some more days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the logic for identifying changes to the read index when merging into a netty composite buffer so that it works with both older versions of netty and netty 4.1.111
Fixes #11284
Backport of #11294