Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Envoy proto sync to 2024-07-06 #11401

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

sergiitk
Copy link
Member

envoyproxy/envoy: Sync protos to the latest imported version envoyproxy/envoy@ab911ac (commit 2024-07-06, cl/651956889).

Should be a noop, just a routine xDS proto update to make upcoming RLQS-related imports simpler.

@ejona86
Copy link
Member

ejona86 commented Jul 23, 2024

Update repositories.bzl as well.

@sergiitk
Copy link
Member Author

Thanks - this was the first step. I think I should've made it a draft to be clear.

@sergiitk sergiitk marked this pull request as draft July 23, 2024 15:36
`envoyproxy/envoy`: Sync protos to the latest imported version
envoyproxy/envoy@ab911ac
(commit 2024-07-06, cl/651956889).

Should be a noop, just a routine xDS proto update to make upcoming
RLQS-related imports simpler.
@sergiitk sergiitk marked this pull request as ready for review July 26, 2024 18:03
@sergiitk sergiitk requested a review from ejona86 July 26, 2024 18:03
@sergiitk
Copy link
Member Author

@ejona86 - updated repositories.bzl. Few questions:

  1. Is there anything I need to do in MODULE.bazel?
  2. Is the CI bazel builds cover everything we want now (including user' side), or do I run any additional checks?

@ejona86
Copy link
Member

ejona86 commented Jul 26, 2024

Is there anything I need to do in MODULE.bazel?

No. This specific dependency is still pulled from the old way, even with MODULE.bazel. So there's nothing extra in this specific case.

Is the CI bazel builds cover everything we want now (including user' side), or do I run any additional checks?

Yeah, you should be good to go.

@sergiitk sergiitk merged commit 96a788a into grpc:master Jul 29, 2024
13 checks passed
@sergiitk sergiitk deleted the xds-sync-proto-2024-07-06 branch July 29, 2024 16:18
sergiitk added a commit that referenced this pull request Jul 30, 2024
`cncf/xds`: Sync protos to the latest imported version
cncf/xds@024c85f (commit 2024-07-23, cl/655545156).

Should be a noop, just a routine xDS proto update to make upcoming
RLQS-related imports simpler, see related #11401.

Note that CEL is only added as a bazel dependency as now it's required
to build cncf/xds. Actual third-party source import will be done in
the follow up PR, where RLQS dependencies are added to the import
scripts.
kannanjgithub pushed a commit to kannanjgithub/grpc-java that referenced this pull request Aug 1, 2024
`envoyproxy/envoy`: Sync protos to the latest imported version
envoyproxy/envoy@ab911ac
(commit 2024-07-06, cl/651956889).

Should be a noop, just a routine xDS proto update to make upcoming
RLQS-related imports simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants