Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Netty to 4.1.110 and tcnative to 2.0.65 #11444

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Upgrade Netty to 4.1.110 and tcnative to 2.0.65 #11444

merged 6 commits into from
Aug 6, 2024

Conversation

kannanjgithub
Copy link
Contributor

No description provided.

@kannanjgithub kannanjgithub mentioned this pull request Aug 6, 2024
Closed
ejona86
ejona86 reviewed Aug 6, 2024
View reviewed changes
SECURITY.md Outdated
@@ -398,7 +398,8 @@ grpc-netty version | netty-handler version | netty-tcnative-boringssl-static ver
1.56.x | 4.1.87.Final | 2.0.61.Final
1.57.x-1.58.x | 4.1.93.Final | 2.0.61.Final
1.59.x | 4.1.97.Final | 2.0.61.Final
1.60.x- | 4.1.100.Final | 2.0.61.Final
1.60.x-1.65.x | 4.1.100.Final | 2.0.61.Final
1.66.x | 4.1.110.Final | 2.0.65.Final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to 1.67. It is too risky to upgrade Netty for this today's release. We won't backport this to the release branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

ejona86
ejona86 reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the changes to gradle/libs.versions.toml and ShadingTest. I see you reverted the ShadingTest change; that would have been the hint that you were not upgrading Netty within the Gradle build.

@kannanjgithub
Copy link
Contributor Author

This is missing the changes to gradle/libs.versions.toml and ShadingTest. I see you reverted the ShadingTest change; that would have been the hint that you were not upgrading Netty within the Gradle build.

Got it, fixed now.

@kannanjgithub kannanjgithub merged commit 70ae832 into grpc:master Aug 6, 2024
15 checks passed
@kannanjgithub kannanjgithub deleted the nettyupgrade4.1.110 branch August 6, 2024 15:08
@dongjoon-hyun dongjoon-hyun mentioned this pull request Oct 17, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kannanjgithub @ejona86