Add a newAttachHeadersServerInterceptor() util #11458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Aug 12, 2024
ejona86
reviewed
Aug 12, 2024
ejona86
reviewed
Aug 13, 2024
| // It isn't too late to call sendHeaders(): !headersSent implies that it hasn't been | ||
| // called yet (obviously). But it also implies that no messages have been sent, because | ||
| // sendMessage() *requires* a preceding call to sendHeaders(). | ||
| sendHeaders(new Metadata()); |
There was a problem hiding this comment.
Oh, you're forcing headers. I don't think we want to do that generally. Maybe that is what you need, but I think it then stops being a general util.
Trailers-only is important to retries, as it delivers the status code without committing.
There was a problem hiding this comment.
I didn't know that - fixed and thanks!
ejona86
approved these changes
Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.