-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power support #2325
Power support #2325
Conversation
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
Also a note, in order to build grpc-java on ppc64le arch, one would need to build protobuf from tag 3.0.2 and protoc-gen-javalite from v3.0.0-javalite tag. And then build grpc-java as - |
This is functionally equivalent to the patch I posted in #2202 (comment) . My patch should fix most of the various non-x86 platforms. The only thing is that it won't allow cross-compiling or choosing to use 32 bit on a 64 bit machine. Would you mind testing it and confirming that it works for powerpc? |
Thanks @ejona86 . |
Hi @ejona86 ,
|
Hi @ejona86, As the older PR of yours doesn't seem to server our purpose for Power, could you please consider my PR for merging? |
@npanpaliya, I don't really believe the test results you provided; I feel like something else was in play. The problem is I will likely quickly break the support if I don't understand why my changes failed to work, because I want to refactor that part of the script. |
retest this please (this is for Jenkins) |
@npanpaliya This PR is probably fine, but gRPC team doesn't have the powerpc hardware to make this always works. If this is submitted, please be aware we may break this in the future. Aside from that generally LGTM. |
Changes required to build grpc-java on ppc64le architecture.
After making these changes, grpc-java still fails for netty-tcnative jar not being available for ppcle_64. So, I built netty-tcnative from source on my system and made grpc-java to point to that. After this, ./gradlew build command does complete successfully.
For netty-tcnative jar, I've requested netty community to publish a jar for ppcle_64 arch on maven's central repository. netty/netty-tcnative#194.
I've also verified my changes on x86_64 platform to ensure nothing breaks there.