Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: Convert to internal ConnectionSpec eagerly #4267

Merged
merged 2 commits into from
Mar 26, 2018

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Mar 24, 2018

This allows ProGuard to remove OkHttp's ConnectionSpec in most cases,
saving about 40 methods. The savings won't be realized until
DEFAULT_CONNECTION_SPEC is removed.

This allows ProGuard to remove OkHttp's ConnectionSpec in most cases,
saving about 40 methods.
@ejona86
Copy link
Member Author

ejona86 commented Mar 24, 2018

@ericgribkoff, so the DEFAULT_CONNECTION_SPEC is public. That makes it a bit unclear on what to do. It may be best to just give up on this particular detail.

@ericgribkoff
Copy link
Contributor

Not sure what to do here, unless we can deprecate DEFAULT_CONNECTION_SPEC and eventually delete it (internally, it seems no one is relying on this). Otherwise the best I can see is having a parallel INTERNAL_DEFAULT_CONNECTION_SPEC, with no internal references to OkHttp's DEFAULT_CONNECTION_SPEC...this saves exactly 4 methods after proguard, so would not be worth the change.

@ejona86
Copy link
Member Author

ejona86 commented Mar 26, 2018

@ericgribkoff, made the change as we discussed. PTAL

@ejona86 ejona86 merged commit 25f3576 into grpc:master Mar 26, 2018
@ejona86 ejona86 deleted the okhttp-connspec-internal branch March 26, 2018 22:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants