Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services: update v1alpha reflection.proto to match grpc-proto repo #4973

Merged
merged 1 commit into from
Oct 18, 2018
Merged

services: update v1alpha reflection.proto to match grpc-proto repo #4973

merged 1 commit into from
Oct 18, 2018

Conversation

zpencer
Copy link
Contributor

@zpencer zpencer commented Oct 18, 2018

More info: grpc/grpc-proto#38

carl-mastrangelo
carl-mastrangelo approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zpencer zpencer merged commit a2ef4c0 into grpc:master Oct 18, 2018
@zpencer zpencer deleted the v1alpha-reflection-deprecation branch October 18, 2018 23:27
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carl-mastrangelo carl-mastrangelo carl-mastrangelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zpencer @carl-mastrangelo