-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netty: converts Proxy handler into new protocol negotiation style #6159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using ProtocolNegotiator interface, it is mimic the behavior to avoid adding other handlers such as WaitUntilActive and KickProtocolNegotiationHandler (no longer exists).
ejona86
approved these changes
Sep 19, 2019
ran-su
approved these changes
Sep 19, 2019
creamsoup
added a commit
to creamsoup/grpc-java
that referenced
this pull request
Sep 20, 2019
creamsoup
added a commit
to creamsoup/grpc-java
that referenced
this pull request
Sep 20, 2019
creamsoup
added a commit
that referenced
this pull request
Sep 20, 2019
creamsoup
added a commit
that referenced
this pull request
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6118