New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #304

Merged

jamesward merged 3 commits into grpc:master from Tails128:patch-1

Nov 16, 2021

Contributor

Tails128 commented Nov 12, 2021

Updated the README.md for the following reasons:

Added a better separation for Gradle and Maven
Added an explanation to use properties in Maven, for beginner-friendliness
Added links to verify what the latest versions of the plugins are
Separated Java and Kotlin GRPC versions to avoid issues
Specified to add os-maven-plugin as it's a prerequisite


          Update README.md

c4ea5d1

linux-foundation-easycla bot commented Nov 12, 2021 •

edited

Loading

The committers are authorized under a signed CLA.

✅ Tails128 (c4ea5d1)

jamesward reviewed

View reviewed changes

compiler/README.md Outdated Show resolved Hide resolved

jamesward reviewed

View reviewed changes

compiler/README.md Outdated Show resolved Hide resolved

jamesward reviewed

View reviewed changes

compiler/README.md Outdated Show resolved Hide resolved

jamesward reviewed

View reviewed changes

compiler/README.md Outdated Show resolved Hide resolved

jamesward reviewed

View reviewed changes

compiler/README.md Outdated Show resolved Hide resolved

jamesward reviewed

View reviewed changes

compiler/README.md Outdated Show resolved Hide resolved

Tails128 and others added 2 commits

November 14, 2021 22:36


          Update README.md

7b6d01d

- Replaced YOUR_X_VERSION with variables
- Changed `protobuf.version` and `java.grpc.version` to fix the max supported values
- Added an `IMPORTANT:` comment to specify the max supported versions of protobuf and protobuf-kotlin


          Merge branch 'master' into patch-1

9b59212

jamesward approved these changes

View reviewed changes

Contributor Author

Tails128 commented Nov 16, 2021

Thanks for the approval 🎉

Just in case I do more contributions, is it fine if I close the PR on my own after the checks pass, or should I let it to the reviewers?

jamesward merged commit 9d91765 into grpc:master

Collaborator

jamesward commented Nov 16, 2021

Thanks @Tails128! I was waiting for the tests to pass and thanks for bringing this back to my attention. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet