Skip to content

Commit

Permalink
Merge pull request #1348 from murgatroid99/grpc-js_proxy_error_reporting
Browse files Browse the repository at this point in the history
grpc-js: Add more information to proxy errors
  • Loading branch information
murgatroid99 authored Apr 10, 2020
2 parents cb39dae + 19d9600 commit 7eca188
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/grpc-js/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@grpc/grpc-js",
"version": "0.7.8",
"version": "0.7.9",
"description": "gRPC Library for Node - pure JS implementation",
"homepage": "https://grpc.io/",
"repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",
Expand Down
4 changes: 2 additions & 2 deletions packages/grpc-js/src/http_proxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,13 @@ export function getProxiedConnection(target: string, subchannelAddress: Subchann
trace('Successfully connected to ' + subchannelAddress + ' through proxy ' + PROXY_INFO.address);
resolve(socket);
} else {
log(LogVerbosity.ERROR, 'Failed to connect to ' + subchannelAddress + ' through proxy ' + PROXY_INFO.address);
log(LogVerbosity.ERROR, 'Failed to connect to ' + subchannelAddress + ' through proxy ' + PROXY_INFO.address + ' with status ' + res.statusCode);
reject();
}
});
request.once('error', (err) => {
request.removeAllListeners();
log(LogVerbosity.ERROR, 'Failed to connect to proxy ' + PROXY_INFO.address);
log(LogVerbosity.ERROR, 'Failed to connect to proxy ' + PROXY_INFO.address + ' with error ' + err.message);
reject();
});
});
Expand Down

0 comments on commit 7eca188

Please sign in to comment.