Add more helpful error message for failure to load extension #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var foundNames = fs.readdirSync(searchPath); | ||
| if (foundNames.indexOf(searchName) === -1) { | ||
| var message = `Failed to load gRPC binary module because it was not installed for the current system | ||
| Expected: ${searchName} |
There was a problem hiding this comment.
Didn't you mean binding_path here instead of searchName ?
There was a problem hiding this comment.
No. searchName is the name of the directory that contains grpc_node.node. And that directory name contains the relevant information for diagnosing this problem. Plus, it can be directly (visually) compared with the contents of foundNames.
There was a problem hiding this comment.
Okay, then maybe rephrase it a tiny bit, because the words "gRPC binary module" to me means grpc_node.node. Maybe you need to add the word "location" next to "Expected" ?
nicolasnoble
approved these changes
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten multiple reports where the extension failed to load, and this will help us diagnose the problem in more cases.