grpc-js: adjust ts definitions to equal native-core #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export MethodDefinition in index.ts and add generic ImplementationType to ServiceDefinition
|
|
|
FYI: the linked CNCF CLA form in Contribution Guidelines is currently unavailable (503), I signed the EasyCLA. |
murgatroid99
reviewed
Apr 9, 2020
murgatroid99
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I tried to use the @grpc/grpc-js package with typescript definitions generated by grpc_tools_node_protoc_ts. But the miss export of type
MethodDefinition(which is exported in native-core's index.d.ts) made it impossible. Also I adjusted the ServiceDefinition.This will also help to for #931
Changes
Export
MethodDefinitionin index.ts and add genericImplementationTypeto
ServiceDefinition.