Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js: Client waitForReady callback fix. Fixes #1352 #1368

Merged
merged 3 commits into from
Apr 20, 2020
Merged

grpc-js: Client waitForReady callback fix. Fixes #1352 #1368

merged 3 commits into from
Apr 20, 2020

Commits on Apr 18, 2020

  1. grpc-js: Remove watcher from queue before calling watcher callback. F… 

    …ixes grpc#1352

In the case where a new watcher is synchronously added to the watcher queue via the
watcher callback, this can result in the callback being called multiple times.

To support this case, the watcher needs to be move removed from the queue
before calling the watcher callback.
    @badsyntax
    badsyntax committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    4e7b94a View commit details
    Browse the repository at this point in the history

  2. grpc-js: Add test for client.waitForReady. Refs grpc#1352

    @badsyntax
    badsyntax committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    615a3c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. grpc-js: Simplify client.waitForReady tests. Refs grpc#1352 

    No need to add a service to the server to test the client.
    @badsyntax
    badsyntax committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7e381f7 View commit details
    Browse the repository at this point in the history