Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Look for ECONNRESET errors by checking the error code #1780

Conversation

murgatroid99
Copy link
Member

This is a different approach to solving the problem I tried to fix in #1705.

@murgatroid99 murgatroid99 requested a review from nicolasnoble May 6, 2021 18:00
@murgatroid99 murgatroid99 force-pushed the grpc-js_econnreset_error_parsing branch from e8efa33 to f009cd7 Compare May 10, 2021 18:06
@murgatroid99
Copy link
Member Author

The logs in #1769 (comment) show the contents of the error we are trying to handle.

@murgatroid99 murgatroid99 changed the title grpc-js: Look for ECONNRESET errors by parsing error messages grpc-js: Look for ECONNRESET errors by checking the error code May 10, 2021
Copy link
Member

@nicolasnoble nicolasnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The associated log is surprising. This seems brittle. Should we check both errno and code with a logical or?

@murgatroid99
Copy link
Member Author

Looking at errno was just a guess. And I actually just realized that that log is showing that the errno is "Unknown system error -104", which is the negative of os.constants.errno.ECONNRESET. The code strings are supposed to be reasonably fixed, so I think checking them is fine.

@murgatroid99 murgatroid99 merged commit 126961a into grpc:@grpc/grpc-js@1.3.x May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants