Added a 100MB maxBuffer since the default 200kb is too small #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the impact of having a maxBuffer size that is too small? |
|
The process crashes. You can see a discussion about it on the node repo: nodejs/node#9829 |
|
I think that if the impact is that bad, we should probably have a wider safety margin. This script should only be run on development machines, and it only spawns one process, so I think 100MB or even 1GB would be reasonable. |
|
@murgatroid99 friendly ping -- submitted the proper changes |
murgatroid99
approved these changes
Mar 26, 2018
olivierboucher
changed the title
olivierboucher
changed the title
|
@murgatroid99 friendly ping. This issue is still on going since grpc-tools has to be released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I ran into this issue where stdout maxBuffer is too small on a large proto codebase. This fixes the issue, 1MB is fair but I can adjust it per your liking.
Also, was not sure if master is the good branch, let me know and I'll re-submit