Update fetch and generate scripts for reflection #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To add the reflection service we need to fetch it and generate the appropriate code. Modifications: - Update proto fetching script to get v1 reflection service - Update proto generating script to generate reflection service code and messages - Also add protos used in tests for the reflection service and generate their descriptor sets Result: Generated code is in place
glbrntt
force-pushed
the
fetch-and-generate-reflection
branch
from
859749a to
6bd9fe8
Compare
gjcairo
reviewed
Dec 20, 2024
dev/protos/generate.sh
Outdated
Comment on lines
101
to
102
| # Messages were accidentally leaked into public API, they shouldn't be but we | ||
| # can't undo that change until the next major version. |
There was a problem hiding this comment.
Good catch, this was copy-pasta!
glbrntt
commented
Dec 20, 2024
dev/protos/generate.sh
Outdated
Comment on lines
101
to
102
| # Messages were accidentally leaked into public API, they shouldn't be but we | ||
| # can't undo that change until the next major version. |
There was a problem hiding this comment.
Good catch, this was copy-pasta!
Co-authored-by: Gus Cairo <me@gustavocairo.com>
gjcairo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To add the reflection service we need to fetch it and generate the appropriate code.
Modifications:
Result:
Generated code is in place