Improve naming of request/response types #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The names of the request/response types are quite stilted. We can improve them by removing the namespacing and by removing the explicit "Single". Modifications: - `ServerRequest.Single` -> `ServerRequest` - `ServerRequest.Stream` -> `StreamingServerRequest` - `ServerResponse.Single` -> `ServerResponse` - `ServerResponse.Stream` -> `StreamingServerResponse` - `ClientRequest.Single` -> `ClientRequest` - `ClientRequest.Stream` -> `StreamingClientRequest` - `ClientResponse.Single` -> `ClientResponse` - `ClientResponse.Stream` -> `StreamingClientResponse` Result: Better naming
gjcairo
changed the title
gjcairo
approved these changes
Oct 1, 2024
glbrntt
force-pushed
the
v2/request-response-naming
branch
from
5b76f60 to
6096bc9
Compare
glbrntt
added a commit
to glbrntt/grpc-swift-protobuf
that referenced
this pull request
Oct 1, 2024
Motivation: Some type names changed in grpc/grpc-swift#2076 and now our tests fail. Modifications: - Update tests Result: Tests pass
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Oct 1, 2024
Motivation: Some names changed in grpc#2076 and now our examples don't compile. Modifications: - Update examples Result: Examples compile
Merged
glbrntt
added a commit
to glbrntt/grpc-swift-nio-transport
that referenced
this pull request
Oct 1, 2024
Motivation: Some names chagned in grpc/grpc-swift#2076 so our generated code isn't up-to-date. Modifications: - Update names - Regenerate code Result: Tests and generated code are up-to-date
glbrntt
added a commit
to glbrntt/grpc-swift-extras
that referenced
this pull request
Oct 1, 2024
Motivation: Some names were changed in grpc/grpc-swift#2076 which we need to update here. Modifications: - Update names of request/response types - Regenerate code Result: Compiles
glbrntt
added a commit
to glbrntt/grpc-swift-extras
that referenced
this pull request
Oct 1, 2024
Motivation: Some names were changed in grpc/grpc-swift#2076 which we need to update here. Modifications: - Update names of request/response types - Regenerate code Result: Compiles
glbrntt
added a commit
to glbrntt/grpc-swift-nio-transport
that referenced
this pull request
Oct 1, 2024
Motivation: Some names chagned in grpc/grpc-swift#2076 so our generated code isn't up-to-date. Modifications: - Update names - Regenerate code Result: Tests and generated code are up-to-date
glbrntt
added a commit
to grpc/grpc-swift-protobuf
that referenced
this pull request
Oct 1, 2024
Motivation: Some type names changed in grpc/grpc-swift#2076 and now our tests fail. Modifications: - Update tests Result: Tests pass
glbrntt
added a commit
that referenced
this pull request
Oct 1, 2024
Motivation: Some names changed in #2076 and now our examples don't compile. Modifications: - Update examples Result: Examples compile
glbrntt
added a commit
to grpc/grpc-swift-nio-transport
that referenced
this pull request
Oct 1, 2024
Motivation: Some names chagned in grpc/grpc-swift#2076 so our generated code isn't up-to-date. Modifications: - Update names - Regenerate code Result: Tests and generated code are up-to-date
glbrntt
added a commit
to grpc/grpc-swift-extras
that referenced
this pull request
Oct 1, 2024
Motivation: Some names were changed in grpc/grpc-swift#2076 which we need to update here. Modifications: - Update names of request/response types - Regenerate code Result: Compiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The names of the request/response types are quite stilted. We can improve them by removing the namespacing and by removing the explicit "Single".
Modifications:
ServerRequest.Single->ServerRequestServerRequest.Stream->StreamingServerRequestServerResponse.Single->ServerResponseServerResponse.Stream->StreamingServerResponseClientRequest.Single->ClientRequestClientRequest.Stream->StreamingClientRequestClientResponse.Single->ClientResponseClientResponse.Stream->StreamingClientResponseResult:
Better naming