Fix a few memory leaks related to unreleased slices in observers and metadata arrays #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…might not be in the future.
timburks
requested changes
Apr 23, 2018
| } | ||
|
|
||
| public init(_ pairs: [String: String]) { | ||
| public init(_ pairs: [String: String]) throws { |
There was a problem hiding this comment.
If I read this correctly, it seems that init throws only because it calls add(), which throws an error that will never occur in practice (because ownsFields is true). Did I miss another throw or do you expect add() to throw other errors in the future? If not, it seems better to use try! add and not throw from init.
There was a problem hiding this comment.
I had this before (see 7b4f47d), but decided that it is safer not to rely on add not failing in that context. It is guaranteed to not fail now, but that might change if the implementation of add gets changes. And I think most clients won't have a problem adding the try statement.
timburks
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.