Add documentation for closure_grpc_web_library #222
Conversation
Yannic
force-pushed
the
bazel_doc
branch
2 times, most recently
from
8512264 to
2ace408
Compare
Yannic
changed the title
Yannic
force-pushed
the
bazel_doc
branch
2 times, most recently
from
59eff81 to
0b0c95d
Compare
|
This is ready for review now. |
| @@ -105,6 +105,88 @@ here. | |||
| - Only unary calls are supported for now. | |||
|
|
|||
|
|
|||
| ### Bazel | |||
There was a problem hiding this comment.
- Can we move this section between "TypeScript Support" and "Proxy Interoperability"
- Can we use two hashes headings "## Bazel Support"?
| ```python | ||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| http_archive( |
There was a problem hiding this comment.
I see the intention here and I think it's a good idea. But this section seems a bit too heavy compared to the rest of the README. Can we shorten it somehow or take the details out to another page? Like perhaps we can move some of the details to https://github.com/grpc/grpc-web/blob/master/net/grpc/gateway/examples/echo/tutorial.md?
| "closure_proto_library", | ||
| ) | ||
|
|
||
| proto_library( |
There was a problem hiding this comment.
I think highlighting these 4 rules is important. Instead of just putting all 4 rules as codes, can we explain what each of these 4 rules are for and why do we need 4 of them?
|
Hi.. I'm closing this PR because all the JS Bazel rules are cleaned up in #1138.. So this change no longer applies.. :) Sorry for the change! |
No description provided.