Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generic client #761

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Update generic client #761

merged 2 commits into from
Mar 24, 2020

Conversation

stanley-cheung
Copy link
Collaborator

@stanley-cheung stanley-cheung commented Mar 24, 2020 •
edited
Loading

Update GenericClient, Request, UnaryResponse, MethodDescriptor

  1. Create a new interface grpc.web.Request. We are eliminating a few arguments to make the formal Request object. It can only be instantiated by calling MethodDescriotor.createRequest.
  2. Update unaryResponse so it's easier to be extended
  3. Add the method createRequest to MethodDescriptor

author:@Jennnnny

@stanley-cheung stanley-cheung merged commit cc5cbf6 into grpc:master Mar 24, 2020
@stanley-cheung stanley-cheung deleted the update-generic-client branch March 24, 2020 06:22
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
@MarcusLongmuir
Allow non-master branches to be built on travis (grpc#761)
1f8f2ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stanley-cheung