-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[generator] Move options parsing into dedicated class #764
Conversation
670c446
to
255003a
Compare
Thanks for the contribution. Yes this refactoring looks good. There's some test failure, PTAL, thanks
|
Looks like I didn't add everything to the commit. Sorry about that! |
mode_(""), | ||
import_style_(ImportStyle::CLOSURE), | ||
generate_dts_(false), | ||
multiple_files_(false){}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: our internal c++ linter doesn't like this ;
after a }
. Please remove it. Thanks!
Thanks, done! |
*** Note: There is no behavior change from this patch. ***
f1e5778
to
dde849c
Compare
*** Note: There is no behavior change from this patch. ***