Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add removeListener and missing metadata event types #874

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Add removeListener and missing metadata event types #874

merged 1 commit into from
Jun 29, 2020

Conversation

danielthank
Copy link
Contributor

Summary

Fixes #873

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 27, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@danielthank danielthank changed the title Add removeListener type and missing metadata event Add removeListener and missing metadata event types Jun 27, 2020
stanley-cheung
stanley-cheung approved these changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@stanley-cheung stanley-cheung merged commit a816d9c into grpc:master Jun 29, 2020
@danielthank danielthank deleted the add-remove-listener-types branch June 30, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add removeListener types in TypeScript
3 participants
@danielthank @stanley-cheung @grpc-kokoro