Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A6 update: change specification of backoff behavior to make sense #452

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

markdroth
Copy link
Member

See discussion in grpc/grpc-go#7514.

@markdroth markdroth requested review from ejona86 and dfawley August 23, 2024 22:44
A6-client-retries.md Outdated Show resolved Hide resolved
A6-client-retries.md Outdated Show resolved Hide resolved
@markdroth markdroth merged commit dc9fd4f into grpc:master Aug 29, 2024
1 check passed
@markdroth markdroth deleted the a6_backoff_fix branch August 29, 2024 15:14
@ejona86
Copy link
Member

ejona86 commented Sep 9, 2024

We need to notify grpc-io about this change, and update the user guide. At least in one place it says "The actual initial backoff delay is a random time period within initialBackoff value configured above (between 0-100ms)."

@markdroth
Copy link
Member Author

markdroth commented Sep 9, 2024

Good catch. I've sent grpc/grpc.io#1356 to update the wording in the retry user guide.

I don't feel like we really need a post to grpc-io about this, but I can do one if you feel strongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants