-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSM O11y: Enable Python #91
Merged
XuanWang-Amos
merged 4 commits into
grpc:main
from
XuanWang-Amos:enable_python_csm_o11y_test
Jun 6, 2024
Merged
CSM O11y: Enable Python #91
XuanWang-Amos
merged 4 commits into
grpc:main
from
XuanWang-Amos:enable_python_csm_o11y_test
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
XuanWang-Amos
force-pushed
the
enable_python_csm_o11y_test
branch
from
June 3, 2024 23:18
74c1a23
to
57e0df3
Compare
copybara-service bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Jun 3, 2024
Passed test run: - [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/bf34eda3-aa41-47b1-87e8-95b66afedb6e) Related Interop framework change: * grpc/psm-interop#91 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36790 PiperOrigin-RevId: 639953335
sergiitk
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve conflicts with main
sergiitk
reviewed
Jun 5, 2024
XuanWang-Amos
force-pushed
the
enable_python_csm_o11y_test
branch
from
June 5, 2024 21:57
1baecae
to
9bb4a66
Compare
sergiitk
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
XuanWang-Amos
force-pushed
the
enable_python_csm_o11y_test
branch
from
June 6, 2024 15:32
9bb4a66
to
093a5cb
Compare
sergiitk
pushed a commit
that referenced
this pull request
Jun 11, 2024
sourabhsinghs
pushed a commit
to sourabhsinghs/grpc
that referenced
this pull request
Sep 26, 2024
Passed test run: - [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/bf34eda3-aa41-47b1-87e8-95b66afedb6e) Related Interop framework change: * grpc/psm-interop#91 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#36790 PiperOrigin-RevId: 639953335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad-hoc run:
Note
otel_scope_name
andotel_scope_version
tag for Python because python Prometheus exporter doesn't have them yet: Prometheus exporter handles instrumentation scope and prevents collisions open-telemetry/opentelemetry-python#3072