Adjust data fields for non–US installations (#17)

* Make US–specific state field optional * stateCode / state_code is also optional --------- Co-authored-by: C Neale <118273+cdn@users.noreply.github.com>
grtwje · Mar 12, 2023 · 43e2906 · 43e2906
1 parent 3703c9a
commit 43e2906
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/accounts_list.rs b/src/accounts_list.rs
@@ -129,7 +129,7 @@ pub struct AccountLocation {
     pub country: String,
 
     /// State of the SolarEdge inverter.
-    pub state: String, // seems US specific. should this be Option<String>?
+    pub state: Option<String>, // seems US specific. should this be Option<String>? probably
 
     /// City of the SolarEdge inverter.
     pub city: String,
@@ -140,7 +140,7 @@ pub struct AccountLocation {
     /// Address line 2 of the SolarEdge inverter.
     pub address2: String,
 
-    /// Zip code 1 of the SolarEdge inverter.
+    /// Zip code 1 of the SolarEdge inverter. Used in UK, in EU?
     pub zip: String, // seems US specific. should this be Option<String>?
 }
 

diff --git a/src/site_location.rs b/src/site_location.rs
@@ -10,7 +10,7 @@ pub struct SiteLocation {
     pub country: String,
 
     /// State of the SolarEdge inverter.
-    pub state: String, // seems US specific. should this be Option<String>?
+    pub state: Option<String>, // seems US specific. should this be Option<String>? probably
 
     /// City of the SolarEdge inverter.
     pub city: String,
@@ -21,7 +21,7 @@ pub struct SiteLocation {
     /// Address line 2 of the SolarEdge inverter.
     pub address2: String,
 
-    /// Zip code 1 of the SolarEdge inverter.
+    /// Zip code 1 of the SolarEdge inverter. Used in UK, in EU?
     pub zip: String, // seems US specific. should this be Option<String>?
 
     /// Time zone of the SolarEdge inverter.
@@ -31,7 +31,7 @@ pub struct SiteLocation {
     pub country_code: String,
 
     /// State (abbreviation) of the SolarEdge inverter.
-    pub state_code: String, // seems US specific. should this be Option<String>?
+    pub state_code: Option<String>, // seems US specific. should this be Option<String>?
 }
 
 #[cfg(test)]