Permit UUID by default #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation by default.
tsg21
force-pushed
the
permit-uuid-by-default
branch
from
25c412a to
59b067f
Compare
tsg21
commented
Jan 13, 2022
Comment on lines
-132
to
-134
| addClassPair(Float.class, "Float"); | ||
| addClassPair(Float.class, "Float"); | ||
| addClassPair(Float.class, "Float"); |
There was a problem hiding this comment.
Note the duplication here, this has been removed.
tsg21
commented
Jan 13, 2022
| @@ -125,41 +128,44 @@ public Invocation deserializeInvocation(Reader reader) { | |||
| addClassPair(boolean.class, "boolean"); | |||
| addClassPair(char.class, "char"); | |||
|
|
|||
| addClassPair(Byte.class, "Byte"); | |||
There was a problem hiding this comment.
There's no need to duplicate the class simple name like this. Just get it from the class directly.
amseager
reviewed
Jan 14, 2022
| addClass(ChronoUnit.class); | ||
|
|
||
| addClass(Transaction.class); | ||
| addClass(TransactionContextPlaceholder.class); |
There was a problem hiding this comment.
That differs from addClassPair(TransactionContextPlaceholder.class, "TransactionContext");, is it ok?
There was a problem hiding this comment.
Good spot! I went through them and failed on the last line. I will undo that - I don't have an interest in accidentally altering behaviour here - the old name might be persisted.
There was a problem hiding this comment.
Fixed. Reverted to the old name for this one.
|
Thanks @tsg21. Merged :) |
badgerwithagun
pushed a commit
that referenced
this pull request
May 14, 2023
* Allow java.util.UUID as one of the types that are allowed for serialization by default. * Revert unintended behaviour change. (cherry picked from commit 7fdac33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
DefaultInvocationSerializerpermitjava.util.UUIDFixes #217