Feature : Quarkus integration

[RomainWilbert]

I work with Quarkus so I created a module to make transaction-outbox work with cdi-api & transaction-api.

Should work with other implentations.

I have made basic tests, feel free to add some if needed !

[badgerwithagun]

Thanks @RomainWilbert, and welcome!

I'll give it a quick review now.

[badgerwithagun]

Added some small thoughts and a couple of questions, but this looks great!

Thank you again for contributing!

[RomainWilbert]

Did you take a look at the tests ?

[RomainWilbert]

Hi @badgerwithagun !

I am a bit confused regarding my CDI Transaction implementation. I observed that :

• I inspired myself from the Spring implementation, but I can't figure why the Transaction is created once and for all within the Transaction manager. There should be one transaction for each proxy call ?
• It seems that the Datasource.getConnection() method returns a different connection on each call...and connections are never closed after proxy calls are done. I reach my connection pool size quite fast (2 new connections for each call).

Thank you for your help

[RomainWilbert]

OK i figured out the issue. I had to use CDI instanciation mecanism in order to make the CDITransactionManager aware of any opened transaction. All seems OK and connections are closed at the end of the process

[RomainWilbert]

Maybe something is not rightly implemented with the connection because I have warnings in logs
[io.agr.pool] (executor-thread-0) Datasource '<default>': Closing open connection prior to commit

[RomainWilbert]

We are benchmarking the module and there are issues with performance and connections lifecycle. This implementation was inspired by the Spring one, but obviously it is not the right angle. I will keep posting updates here

[badgerwithagun]

Any luck @RomainWilbert ?

[RomainWilbert]

False alert. We did some real time debug to ensure everything was OK on that part. Our issues came from elsewhere : a hardcoded timeout on a request in a DAO...
The warning Closing open connection prior to commit comes from the connection wrapper, there is a reaper that checks if connection & statements are closed before commit, and it is called before the afterCompletion event...one way to prevent the warnings is to return the connection instead of the wrapper in the TransactionManager : but required to be careful on statement & connection closing as the reaper secure closing is not called anymore before commit.
public final Connection connection() { try { ConnectionWrapper connectionWrapper = (ConnectionWrapper) datasource.getConnection(); Connection connection = connectionWrapper.getHandler().rawConnection(); log.trace("Connection : " + connection); connectionWrapper.close(); return connection; } catch (SQLException e) { throw new RuntimeException(e); } }